Skip to content

Enable string constructor to parse payloads of NANs #1219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mborland merged 19 commits into from
Nov 6, 2025
Merged

Enable string constructor to parse payloads of NANs #1219

mborland merged 19 commits into from
Nov 6, 2025

Conversation

@mborland
Copy link
Member

@mborland mborland commented Nov 6, 2025

Closes: #1184

mborland added 16 commits November 5, 2025 12:04
@mborland mborland added this to the v6.0.0 milestone Nov 6, 2025
@mborland mborland self-assigned this Nov 6, 2025
@mborland mborland added enhancement New feature or request Boost Review Collected Comments from Boost Review Period labels Nov 6, 2025
@codecov
Copy link

codecov bot commented Nov 6, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.2%. Comparing base (c6dd35a) to head (14d4bbf).
⚠️ Report is 37 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           develop   #1219     +/-   ##
=========================================
+ Coverage     99.2%   99.2%   +0.1%     
=========================================
  Files          257     259      +2     
  Lines        17134   17193     +59     
  Branches      1935    1941      +6     
=========================================
+ Hits         16994   17054     +60     
+ Misses         140     139      -1
Files with missing lines Coverage Δ
include/boost/decimal/charconv.hpp 97.6% <100.0%> (+0.1%) ⬆️
include/boost/decimal/decimal_fast128_t.hpp 96.0% <ø> (ø)
include/boost/decimal/decimal_fast32_t.hpp 100.0% <ø> (ø)
include/boost/decimal/decimal_fast64_t.hpp 100.0% <ø> (ø)
include/boost/decimal/detail/cmath/nan.hpp 92.4% <100.0%> (-0.5%) ⬇️
include/boost/decimal/detail/parser.hpp 96.3% <100.0%> (+0.4%) ⬆️
include/boost/decimal/detail/write_payload.hpp 100.0% <100.0%> (ø)
test/github_issue_1054.cpp 100.0% <100.0%> (ø)
test/test_from_chars_nan_payloads.cpp 100.0% <100.0%> (ø)

... and 2 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c6dd35a...14d4bbf. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mborland mborland merged commit 9d09df9 into develop Nov 6, 2025
77 checks passed
@mborland mborland deleted the 1184 branch November 6, 2025 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@mborland mborland

Labels

Boost Review Collected Comments from Boost Review Period enhancement New feature or request

Projects

None yet

Milestone

v6.0.0

Development

Successfully merging this pull request may close these issues.

Allow string constructors to process payloads

2 participants

@mborland